Table of Contents
Table of Contents |
---|
Open questions
Business Questions
Is there a business rule that demands that only verified phone numbers can be used in customer search?
Business Answers
Tech Questions
Why do two different Interfaces for lookupByPhone records exist? (one in
user-service
and another inintl-packages
)Does accessing user-service phone lookup records from intl-packages violate the current architecture?
Since Admin App is not using Launch Darkly, does it have a strategy defined for Feature Toggles?
Tech Answers
This is legacy from US, and neither of them are used today, since sign up via phone is disabled in international.
Yes, we should create a new endpoint in user-service to search by phone number.
Business problem
This feature aims to implement the option to search for customers by phone in RBI Admin tool. This was a business request from Iberia (
Jira Legacy | ||||||
---|---|---|---|---|---|---|
|
Tech Discovery
Architecture AS-IS
Today, Admin Tool only has the option to search customers by email or Cognito ID. The search by email is exemplified by the following sequence diagram.
The most direct solution is using intl-packages
, which already exposes a method to search users by phone number and DynamoDB queries for userLookupByPhone
records associating phone numbers to Cognito IDs. However, there is a divergence between the records created using intl-packages
and the ones created by user-service
, as can be seen below:
intl-packages:
Code Block | ||
---|---|---|
| ||
{ pk: phoneNumber, pk2: cognitoId, sk: current/user-lookup-by-phone sk2: current/user-lookup-by-phone/{date} } |
user-service:
Code Block | ||
---|---|---|
| ||
{ pk: phone#${phoneNumber}, pk2: phone_user#${cognitoId}, sk: v0_UserPhone, sk2: v0_UserPhoneUserPhoneLookUp, } |
The user-service
record is created when a user verifies their phone number via SMS. As far as we can tell, no one is using intl-packages
lookup records since its only reference is its own test.
This poses a problem, given that Iberia doesn’t require the customer to verify its phone, since they can use email.
Proposed solution
Add the option in intl-packages
to search users by phone number, and change user-service API to create/update lookupByPhoneNumber
records whenever there are changes in the customer's phone number.
It’s important to notice that since lookupByPhoneNumber
records haven’t been created for existing users, a script will have to be developed to scan all users in DynamoDB and create their associated lookup records.
Necessary changes - summary
User Service API: Adapt GET user endpoint to also search by phone number
User Service API: Adapt the
create
method in user service to create alookupByPhoneNumber
record if a phone number is informedUser Service API: Adapt
update-user
lambda to update or create alookupByPhoneNumber
record if the phone number changedUser Service API: Add a
isPhoneNumberVerified
field tolookupByPhoneNumber
interface. This is important to avoid impacting https://rbictg.atlassian.net/wiki/spaces/EGMT/pages/4329078785/Solution+Phone+Number+Authentication+for+BK+SA#Customer-support-toolUser packages: Change
getByPhoneNumber
to use User Service API instead of directly accessing the databaseAdmin App Backend: Create a GraphQL query to request customers by phone number
Admin App Frontend: Add the option to search customers by phone using the new query
DynamoDB: Develop a migration script to create
lookupByPhoneNumber
for existing customers
Diagrams
Search customer by phone sequence diagram:
Necessary changes - details (WIP)
intl-packages
Create the option to search
lookupByPhone
records created byuser-service
Expose the new
searchByPhone
option
This changes are already implemented in this git branch: https://github.com/rbilabs/intl-packages/pull/961
intl-user-service
In this service, the lookup record is created by createPhoneRecord
function, which is called only in the verifyPhoneNumber
method (https://github.com/rbilabs/intl-user-service/blob/master/src/verification/verify-phone.service.ts#L112-L117)
There are a couple of possible solutions to create these records whenever a customer phoneNumber
is created or updated, for example:
Call
createPhoneRecord
in bothsignUp
user and update user details endpointsCreate a lambda responsible for creating and updating lookup records which is triggered using DynamoDB streams.
intl-admin-app
Create a GraphQL query that uses the
searchByPhone
method exposed by intl-packagesUpdate the UI to display the search by phone number option
These main changes are implemented in this git branch: https://github.com/rbilabs/intl-admin-app/pull/242
However, Admin App currently doesn’t use Launch Darkly, which makes it harder to control the feature activation for different markets and makes it riskier. Possible alternatives are:
Pros | Cons | |
---|---|---|
Add and configure Launch Darkly in Admin App |
|
|
Implement FT using environment variables |
|
|
Only display the search by phone option in Iberia market |
|
|