...
The code reviews are per task;
Create a feature flag to your feature and create a technical debt to remove the flag posteriorly
Analyze cicle-ci: https://app.circleci.BRANCHScom/projects/project-dashboard/github/rbilabs/
Check if your PR is good at the pipeline workflow
After the merge to master, check if all is well and if the job runs till the end
Branchs and commits
Always create a branch referring to sub-task from
master
branchWe work in a trunk-based like:
Master branch ← sub-task branch
We should avoid to create Story branch. Only as last resource and if makes sense
Branch name using the Jira ID and sub-task name:
examples:
To features: feat/IBFEC-123-sub-task-name
To bugs: fix/IBFEC-123-sub-task-name
To bugs in prod or fires: hotfix/IBFEC-123-sub-task-name
Commit name:
Prefix - is the type of your commit. Accepted prefixes are:
feat | fix | hotfix | build | docs | ci | perf | refactor | style | test
examples:
[IBFEC-123] feat: added feature flag on component
[IBFEC-123] hotfix: fix to resolve save error
[IBFEC-123] test: create unit test componentAnalyze each commit on cicle-ci:
This is based in Conventional Commits:
- appcircleci.comprojects/project-dashboard/github/rbilabs
Good practices to Open the PR
...