Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Repos that we’ll change:

Packages: https://github.com/rbilabs/intl-packages

Loyalty: https://github.com/rbilabs/intl-loyalty

Fulfillment: https://github.com/rbilabs/intl-fulfillment-service

PSP Paycomet Service:https://github.com/rbilabs/intl-psp-paycomet-service

Whitelabel Graphql: https://github.com/rbilabs/intl-whitelabel-graphql

Table of Contents

Sequence Diagram

Lucidchart
pageCount1
autoUpdatefalse
alignleft
typerich
autoSize1
macroId212c18aa-82a2-44ac-8050-f390618c5f25
instanceId920ae5b1-83d6-3e36-b794-1710780f64f3
pages
width700
documentTokenv2_553b49157110c9a058af38fe91f599cb1b5e1258ab98da315d6f1ca4a1227d7e-a=133831322&c=920ae5b1-83d6-3e36-b794-1710780f64f3&d=68c0744f-0f16-45a8-98dc-41f5610b0e39&p=4447830094
documentId68c0744f-0f16-45a8-98dc-41f5610b0e39
updated1705609545171
height500


Business rules


Tasks breakdown

Task 1: Add Bizum payment to packages

Repo: intl-packages

POC: https://github.com/rbilabs/intl-packages/pull/1024/files

Bizum payment must be added in CartGooglePaymentTypeExclusion, XenialDeliveryPayTypeId and RBIPaymentCard.

After adding this, run the yarn build command.
Reminder: when making any modifications to the package, the other repositories only receive these new modifications after running Bumps.

*Consider only changes to ENUM and Types in POC

Task 2: Update Loyalty

Repo: intl-loyalty

  • In the "loyalty-middleware" folder, update the packages

  • Bump the new version of @rbilabs/intl-payments in intl-loyalty/loyalty-middleware

  • Build the loyalty middleware: yarn install && yarn build

  • Generate the loyalty middleware sdk: yarn sdk:generate . This creates loyalty middleware SDK with MdwRBIPaymentCard

  • Then, finally, in WL-GQL you can load this latest version of intl-loyalty-middleware-sdk

image-20240206-113818.pngimage-20240206-114456.png

PR Reference: https://github.com/rbilabs/intl-loyalty/pull/426/

Task 3: Fulfillment

Repo: intl-fulfillment-service

  • Update Packages

  • Define Bizum in CARD_TYPE_TO_MDW

    image-20240119-112137.png

  • Define Bizum in MAP_GQL_CART_PAYMENT_TO_COMMON

    image-20240119-112240.png

  • Define Bizum in MAP_GQL_CART_PAYMENT_TO_RBI_COMMON

    image-20240119-112335.png

Task 4: Added Bizum payment to Paycomet

Repo: intl-psp-paycomet-service

POC: https://github.dev/rbilabs/intl-psp-paycomet-service/pull/229/

Today, the PSP only works with PayPal, but refactoring is needed so that payment with a link works for PayPal and Bizum.

To works Bizum on the Paycomet API, it’s necessary just configure the methods fields with 11.

Code Block
languagejs
const checkout = await this.client.exec(
        region,
        new TransactionLinkUrl.Request({
          terminal: store.terminal,
          language: request.language ?? '',
          operationType: 1,
          payment: {
            terminal: store.terminal,
            methods: [11],
            amount: request.amount,
            order: request.rbiOrderId,
            currency: 'EUR',
            secure: 0,
            productDescription: request.orderDescription,
            userInteraction: 1,
            urlOk: returnUrl,
            urlKo: returnUrl,
          },
        }),
      );

But the implementation must be modular, work for PayPal and Bizum without having code repetitions.

My suggestion is to refactor all files and code related to PayPal, and make it modular, with a name suggestive of payment with Link.

Example:

image-20240118-195450.pngimage-20240118-195555.png

In the POC, I left this ready, but validation from the team is necessary.

If necessary for creating a separate task:

  • Links

    • Add BIZUM in TypePayment and define Controller DTO.

    • Refactor to remover PayPal and add Link (Pay with Link).

    • Generate Link to PayPal or Bizum.

  • Outcome

    • Add BIZUM in TypePayment and define Controller DTO.

    • Refactor to remover PayPal and add Link (Pay with Link).

  • Payment Core

    • Add TransactionMethodId to Bizum with code 11

      image-20240118-200459.png

    • Change function to identify payment with PayPal to identify payment with Link.

      image-20240118-200654.png

  • Payment

    • Change confirm payment function to works all payments with link and not only Paypal: this.confirmPaymentPaypal => this.confirmPaymentLink

Task 5: Added Bizum payment to GraphQL.

Repo: intl-whitelabel-graphql

POC: https://github.com/rbilabs/intl-whitelabel-graphql/pull/752

  • It’s necessary to add BIZUM in CartPaymentCardType (order.gql) and generate GraphQL.

    • Run yarn update-packages

    • Add Bizum

      image-20240119-112052.png

    • Run yarn graphql:types

  • Define Bizum in CARD_TYPE_TO_MDW

    image-20240119-112137.png

  • Define Bizum in MAP_GQL_CART_PAYMENT_TO_COMMON

    image-20240119-112240.png

  • Define Bizum in MAP_GQL_CART_PAYMENT_TO_RBI_COMMON

    image-20240119-112335.png

  • Now run command:

    • yarn build