Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Today, Sanity has the footer content configured in Marketing Content → Features → Feature Footer, where managers can include different rows and columns with the information they need. For BK-PT, this includes the image and link for “livro de reclamações”.

...

After checking other markets (BK-ES, BK-DE, BK-CH, BK-UK, PLK-CH and PLK-ES), it appears that BK Portugal is the only one using ImageWidget configuration in sanity. This reassure us that the proposed change won’t have undesired impacts and also provide the possibility for these markets to add an image as a link in the future.

...

After the change is implemented and the feature toggle is activated, PT market can update sanity “Livro de Reclamações“ image with the appropriate link (and remove the extra text link that exists today, if desired) to solve the issue.

We consider this the preferred solution, taking into consideration the following Pros and Cons:

Pros:

Cons:

  • If a bussiness case where an Footer Image Widget One possible con could be a business requirement in which the image cannot be a link, but the field attributionLink still has to have a link but cannot be clickable exists, this solution won’t workvalue. However, we can be certain this is not the case today since the WL GraphQL query doesn’t include it.

Create a new Option object for ImageLinks or add a new toggle field to imageWidget. The first requires adding a new case in the footer column switch, and implementing a new component for images with link. The second is very similar to Option 1, except that the condition for the link would be the new field toggle instead of attributionLink. Both cases will require changes in the sanity schema, that in turn, might impact any automatic synchronization between sanity and other systems.

Pros:

  • Doesn’t impact the existing Footer ImageWidgets, since either a new field is added, or an entire new object is created.

Cons:

...

  • Changes span more than one repository and requires manual update of packages.