Table of Contents | ||
---|---|---|
|
Considerations
...
Platform wide change, this should work on every market;
Identify Payment Methods as Online or Physical Payment
We should identify on both Frontend (WhitelabelApp) and in the backend (Payment Service). The main implementation and first barrier should be the frontend (hidding the Physical Payments from the payment methods dropdown). In other hand, the backend should grant that, even somehow the Frontend allow the Physical Payment, it will be blocked.
Frontend: Add onlinePayment at Payment Method Interface
Add a new property called onlinePayment at this interface
Update the constants that implement this interface adding the onlinePayment method here, the configuration should be:
const | onlinePayment value |
---|---|
PAYPAL_PAYMENT_METHOD_PLACEHOLDER | true |
BLIK_PAYMENT_METHOD_PLACEHOLDER | true |
SODEXO_VOUCHER_PAYMENT_METHOD_PLACEHOLDER | false |
CHEQUE_GOURMET_VOUCHER_PAYMENT_METHOD_PLACEHOLDER | false |
SODEXO_PAYMENT_METHOD_PLACEHOLDER | true |
CHEQUE_GOURMET_PAYMENT_METHOD_PLACEHOLDER | true |
PAYMENT_ON_DELIVERY_CARD_PAYMENT_METHOD_PLACEHOLDER | false |
BIZUM_PAYMENT_METHOD_PLACEHOLDER | true |
WAYLET_PAYMENT_METHOD_PLACEHOLDER | true |
Create a new method to verify if a payment type is online or not. This method should grant that cash will always be considered false regardless the configuration. (as you can see, there’s no configuration for cash in the table above, that represents the state/payment/constats.ts file)
Feature Flag
We should create a new Feature Flag on Launch Darkly with the following definitions:
Name: physical-payments-limitation
Description:
This flag enable the Physical Payment Limitation, to avoid joke/fake orders on delivery. It intends to allow online-only payments on certain conditions, the implemented rules are below (please update this description when creating new rules):
First Order Limit (limit_first_order) → Limit every first order of our guests in our platform, equal or greater then a given amount, to be online paid only.
Total Amount Limit (limit_total_amount) → Limit every order greater or equal then a given {amount} to be online paid only.
Last Delivery Failed (limit_last_delivery_failed) → When the previous delivery order failed, the subsequent one should be paid online only
Variation Value:
...
This should only affect delivery orders.
Frontend Preparation
Status colour Blue title Ready for dev
Rules Implementation
For the first order with a value >= X €, only online payment will be allowed, where X is configurable. The initial intention is to set it to 20 €.
Questions:
How can we identify the first order of a user? Is there any mechanism in place?
Solution
We can get advantage of gateway query getUserOrders, this query returns all orders from the logged user with a count. We query this when the browser loads the payment method screen. This is the response:
New user without any order.
When this count is 0, we don’t show Physical Payments.
For subsequent orders with a value >= X €, only online payment will be allowed, where X is configurable. The initial intention is to set it to 50 euros.
Solution:
We already have a cash payment limit, but it’s only for cash. We should create a new flag to all Physical Payments and verify before we show the payment methods dropdown to our customer, removing all physical payment.
Create feature flag for this limit
Evaluate when creating PaymetMethods
Status colour Blue title Ready for dev
...
Status colour Blue title Ready for dev
If the last order was paid in Physical Payments and there was a delivery failure (e.g. a joke order), the next order will only allow online payment
The tablet expeditor app has some order cancellations actions, these actions are sent through Delivery Events API but they are not stored in any of our databases.
We believe this ticket can potentially unblock us, to get the correct reason a delivery have failed:
, it’s currently at “To Do” statusJira Legacy server System Jira serverId 255417eb-03fa-3e2f-a6ba-05d325fec50d key IREQ-1123
Once we have the correct reason of order or delivery cancelations stored in the backend we’ll be able to identify, in the cash limitations methods, if the last delivery failed for some of the reasons we want and remove Physical Payments.
To dos:
Get together the cancelation reasons we want to consider for this rule
Create the feature flag for this rule
Implement on Cash Limitations check this rule
Status colour Red title
...
BLOCKED