Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 6 Next »

Repos that we’ll change:

Packages: https://github.com/rbilabs/intl-packages

PSP Paycomet Service:https://github.com/rbilabs/intl-psp-paycomet-service

Payment Service: https://github.com/rbilabs/intl-payment-service

Loyalty: https://github.com/rbilabs/intl-loyalty

Whitelabel Graphql: https://github.com/rbilabs/intl-whitelabel-graphql

Whitelabel App: https://github.com/rbilabs/intl-whitelabel-app

Figma: Schroer, Gabriel (Deactivated)

Sequence Diagram


Business rules

  • A new Bizum payment must be created for Paycomet.

  • This payment must work the same as Paycomet's PayPal, it must generate a link and be used in an Iframe where the payment will be processed.

  • The confirmation/tracking page should show the correct text in the payment reminder for this new payment method

  • The receipt email should show the correct payment option for this new payment method

  • The new method should be available in the user account methods list

  • We have to pay attention to changes from the Payments team, they are making some changes to their routine, and this new implementation cannot change the current behavior.

    There are two flags that change the application's behavior: enable-paycomet-webhook-notifications (BE) and enable-backend-commit-order (BE & FE), we must test both ways, with the flags enabled and disabled.


Tasks breakdown

Task 1: Create a new feature flag

Flag should be added in: src/utils/launchdarkly/flags.ts

Suggestion name: enable-bizum-paycomet

This flag is used to show Bizum payment in payment lists.

Example of use: frontend/src/state/payment/hooks/use-payment.tsx

Task 2: Add Bizum payment to packages

Repo: intl-packages

Bizum payment must be added in CartGooglePaymentTypeExclusion, XenialDeliveryPayTypeId and RBIPaymentCard.

After adding this, run the yarn build command.
Reminder: when making any modifications to the package, the other repositories only receive these new modifications after running Bumps.

POC: https://github.com/rbilabs/intl-packages/pull/1024/files

*Consider only changes to ENUM and Types in POC

Task 3: Added Bizum payment to Paycomet

Repo: intl-psp-paycomet-service

Today, the PSP only works with PayPal, but refactoring is needed so that payment with a link works for PayPal and Bizum.

To works Bizum on the Paycomet API, it’s necessary just configure the methods fields with 11.

const checkout = await this.client.exec(
        region,
        new TransactionLinkUrl.Request({
          terminal: store.terminal,
          language: request.language ?? '',
          operationType: 1,
          payment: {
            terminal: store.terminal,
            methods: [11],
            amount: request.amount,
            order: request.rbiOrderId,
            currency: 'EUR',
            secure: 0,
            productDescription: request.orderDescription,
            userInteraction: 1,
            urlOk: returnUrl,
            urlKo: returnUrl,
          },
        }),
      );

But the implementation must be modular, work for PayPal and Bizum without having code repetitions.

My suggestion is to refactor all files and code related to PayPal, and make it modular, with a name suggestive of payment with Link.

Example:

image-20240118-195450.pngimage-20240118-195555.png

In the POC below, I left this ready, but validation from the team is necessary.

POC: https://github.dev/rbilabs/intl-psp-paycomet-service/pull/229/

If for necessary created task separate:

  • Links

    • Add BIZUM in TypePayment and define Controller DTO.

    • Refactor to remover PayPal and add Link (Pay with Link).

    • Generate Link to PayPal or Bizum.

  • Outcome

    • Add BIZUM in TypePayment and define Controller DTO.

    • Refactor to remover PayPal and add Link (Pay with Link).

  • Payment Core

    • Add TransactionMethodId to Bizum with code 11

      image-20240118-200459.png

    • Change function to identify payment with PayPal to identify payment with Link.

      image-20240118-200654.png

  • Payment

    • Change confirm payment function to works all payments with link and not only Paypal: this.confirmPaymentPaypal => this.confirmPaymentLink

  • No labels