Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 12 Next »

Table of contents

Definition

Status

NOT STARTED IN DESIGN IN DEVELOPMENT COMPLETED

RBIberia Owner

Paula

RBI Owner

Luke

Open questions

We need to constantly make this section become empty.

We need to add the brand icons for each of the account menu options. Several LD flags control this (Hainzenreder, Diego not sure there will be a tech limitation and we will need same icons for both brands and cannot customize in sanity, since this is set through LD flags today)

https://app.launchdarkly.com/default/staging-plk/features/enable-account-sections-variations/targeting

https://app.launchdarkly.com/default/staging-plk/features/enable-settings-geolocation/targeting

Read info here + the account line of “settings” that we developed as part of coupon geolocation

Hainzenreder, Diego and Fisher, Luke to decide if this is hidden behind LD flag or not

Requirements

Problem statement

The menu items located in the customer's profile on Popeyes are unclear. They do not present a clear hierarchy of first and second level links, as well as it is not evident that they are clickable. The current app also uses icons that identify each area, and this is not available in the new version. 

Acceptance criteria

  • Icons are displayed on first-level menu items and with the arrow after the label

  • There is greater emphasis on the links for " Encuentra tu restaurante" and " Inicia sesión o crea tu cuenta" 

  • Second-level icons are highlighted

Success metrics

Solution

Potential

  • Add icons for each menu item. 

  • Prioritize the importance of each link with 2 different solutions: 

  • Orange color for the first level 

  • Underline for the second level 

Design

Figma design here: PLK - BK

Development

  • Task 1 - Create feature flag

  • Task 2 - Add new icons

    • Some icons we have in storybook, so just need to import here.

    • But new icons we need to add in the repository ctg-components-library, for to get new icons here.

    • Add the new icons in storybook too.

  • Task 3 - Create a new component for icon

The items of menu are controlled by feature flags, to activate all flags, you can add true in hard-code.

This menu it is in src/pages/account/index.tsx

Each item of menu are compost by component ArrowLink src/components/arrow-link/arrow-link.tsx.

On the component ArrowLink we have two components, one case is external link and one case not external link, we will use the not external link StyledLink, and we can add a new prop, because this component is used in others locals, so we will to add “customIcon or (other name)” prop and this prop is optional. And in the component for account/index we add this prop, "customIcon“ with icon name and this name is of icon in component-library. And into ArrowLink add flag for task 1 for validate if show or not the icon.

Into ArrowLink we have two validations, one for has a name icon, and other for flag is true, if two fieds is ok, so show icon.

We need to restructure the component ArrowLink for case is true show new icon and case false not changed the layout.

Attention, because the font label, color of label and icons changed and now the colors changed according to brand. (look figma) - The colors used have in file primitives.ts, for intl-whitelabel and ctg-components-library.

Assumptions

Release

  • No labels