Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 69 Next »

🛠️ Potential Solutions

Currently, the restaurant lacks the ability to choose which payment methods to use, particularly offline options like cash, vouchers, or at-home terminals, during the delivery process. RBIIberia aims to provide this flexibility to the restaurant, allowing it to temporarily disable the "at-home terminal" payment method whenever it is not available.

We have two tools that can be used by restaurants to configure payment method availability: Sanity and DOP.

Option 1: Use Sanity for payment methods configurations - Discarded

(plus) Pros

  • This is the standard tool for Fz’s (market) configuration persona

  • Sanity is deployed for every Fz (market) in RBI

(minus) Cons

  • Operations team doesn’t have access to Sanity.

    • Possibilities:

      • New sanity access roles for the operations team

      • Operations team would require Fz’s configurators to update it if necessary

  • For Restaurant configuration level, it should be done one by one (despite that it can be added a new configuration to do for all restaurants at once).

  • It’s not possible to do these configurations for the offline payment methods.

Option 2: Use DOP for payment methods configurations - (Chosen by business)

(plus) Pros

  • This is the tool used by the Operations team. If we use this one, they don’t need to learn and to get access to use another tool.

  • This tool supports the configurations for offline payment methods (mainly for terminal machine at home and cash).

  • Possibility to do these configurations at restaurant level. But it can also be extended to edit for multiple restaurants, just as "Cash Limitation feature".

  • It’s possible to configure payments on DOP and create a “view only” version on Sanity. Then WL can query this information.

(minus) Cons

  • DOP is used only by Iberia and Germany. This solution will only impact these markets.

✅ Proposed Solution

PART I - Add Payment Methods List on DOP

We need to implement a solution that allows users to temporarily disable certain offline payment methods (e.g., vouchers, cash) for specific restaurants in the DOP. When a payment method is disabled, it will not be displayed in the WL-app for that restaurant.

Currently, the management of available payment methods by market and brand is hard-coded in the Front-end (Whitelabel). This implementation relies on LD feature flags from the guest app project , making it impossible to retrieve this information from other services, such as DOP.

To address this issue, we need to prioritize finding a solution. Here are the options we are considering:

After receiving feedback from the Menu team (Rafael Souza, Eduardo Yosida, and Lucas Palencia) and the Transactions team (Felipe Rooke), we have concluded that this solution is the best option at this time.

In this option, we will create a new document for the list of payment methods. The DOP already has synchronization with Sanity, allowing it to access this information and determine which methods will be active or inactive. This way, the restaurant will have its payment methods organized by market and brand.

This new screen (sanity document) will only list the available offline payment methods for the market. The restaurant level configuration will be stored in the restaurant documents, and managed via DOP as detailed in below.

solution2.png

The design team has not created these screens yet, this is just a sketch

Field and Details

Screen on Sanity

The new screen in the Restaurant Menu.

In this screen we can add, remove and edit the payment method

image-20241031-140933.png

Screen where we can add new payment

image-20241031-141038.png

Title of Payment (name) - Payment title, we will use this title to save the status within documents restaurant for identification

image-20241016-124738.png

Payment method brand (paymentMethodBrand) - a string key that must match the one in WL_app. We will use this value to ensure consistent validation in the front-end.

Example: “CASH“, “SODEXO_VOUCHER“, “PAYMENT_ON_DELIVERY_CARD”

image-20241016-124752.png

Process to Retrieve Payment Methods in DOP.

getPayment.png

In the GQL back-end, we will create a utility to retrieve this information for Sanity. In the future, when we are able to access the payment method list from the back-end service, we will need to develop a new utility to fetch this information. We can use the same structure, which will lead to fewer changes and less refactoring.

Data example that will return of Sanity - PaymentMethod

"paymentMethods": [
  {
    "name": "Cash",
    "paymentMethodBrand": "CASH"
  },
  {
    "name": "Sodexo Voucher",
    "paymentMethodBrand": "SODEXO_VOUCHER"
  },
  {
    "name": "Ticket Restaurant Voucher",
    "paymentMethodBrand": "TICKET_RESTAURANT_VOUCHER"
  }
];

(plus) Pros:

  • Sanity is divided by market, brand, and region, allowing control over payment types by market;

  • No coding is required when adding a new payment method, just include the information on Sanity;

  • Only DOP manage the status of payment

(minus) Cons:

  • Access will not be limited to the technical audience, allowing other users to add methods without difficulty;

  • When adding a new payment method in the WLapp, we also need to register it in Sanity.

  • The Transactions team is currently working on an improvement to get the payment method for a service, so this screen may be deprecated in the future.

Option 2 - Centralize Payment Methods in the Back-end

Change the source from which the application retrieves payment methods. Currently, this information is fetched from the front-end (Whitelabel). By moving this responsibility to a back-end service, we will be able to access this information from anywhere, ensuring the maintenance of more consolidated payment methods.

In this solution, we will add all payment methods to a separate back-end repository, maybe in intl-payment-service or intl-packages. Additionally, we can create a new API to retrieve this information in any other service, such as the DOP.

Once the state of each payment method is selected, this information will be saved in the "Restaurant" document within Sanity.

We will need to move all feature flags related to payment methods from the front-end to the back-end.

The Transaction Team is currently working on this, but they will need more time to complete it (approximately 3 to 4 months).

(plus) Pros:

  • All services that need to access payment methods can query the back-end service to obtain this information;

  • A single source for payment methods;

  • More consolidated application.

  • Get Payment Method by brand and market

(minus) Cons:

  • Significant change in the payment architecture;

  • High effort required;

  • High complexity;

  • The Transactions team is already working in this improvement.

Option 3 - Payment Methods Hard Code on DOP

In this solution, we will add all offline payment methods directly to the DOP source code. The display of these payment methods will be implemented for all markets, even if a specific market does not have any available payment method.

Once the status of each payment method is selected, this information will be saved in the "Restaurant" document within Sanity.

Note: If the user marks a nonexistent payment method for a market as true, it will not be displayed on the whitelabel screen.

Example of data to show payment method:

"paymentsMethod": [
  {
    "name": "Cash",
    "keyLokalise": "paymentMethods.cash",
    "paymentMethodBrand": "CASH",
    "isOnlinePayment": false
  },
  {
    "name": "Sodexo Voucher",
    "keyLokalise": "paymentMethods.sodexoVoucher",
    "paymentMethodBrand": "SODEXO_VOUCHER",
    "isOnlinePayment": false
  },
  {
    "name": "Ticket Restaurant Voucher",
    "keyLokalise": "paymentMethods.ticketRestaurantVoucher",
    "paymentMethodBrand": "TICKET_RESTAURANT_VOUCHER",
    "isOnlinePayment": false
  }
];
  • paymentsMethod List:

    • name: a string used for easy identification of the payment method, and we can use this name to show on Sanity.

    • keyLokalise: a string that may contain a key from Lokalise.

    • paymentMethodBrand: a string key that must match the one in WL_app. We will use this value to ensure consistent validation in the front-end.

    • isOnlinePayment: A boolean value to determine whether the payment method is online or offline. Initially, we will only use offline payment.

solution2_testt.png

(plus) Pros:

  • Fast development;

  • Simple solution;

(minus) Cons:

  • we don't have separation by market;

  • All payment method are presented to all markets;

  • When added new market in WL-app, need to add in DOP as well;

Option 4 - Payment Methods List in Secrets

In this solution, we would create a Secrets for each market, where each secret would include only the payment methods available for that market. The DOP would use these payment methods as a basis to identify which ones are available and determine which are active or inactive. When saving this information, it would be sent to Sanity, where each payment method would be recorded.

solution5.png

These Secrets will be created in packages/secrets/src/definitions and have the following interface:

{
  "pk": {
    "S": "rbi/dev/plk/es/payment-method"
  },
  "sk": {
    "S": "current"
  },
  "createdAt": {
    "S": "2024-10-23T12:23:35.389Z"
  },
  "description": {
    "S": "Secrets for the payment method in DOP FZ-Portal."
  },
  "updatedAt": {
    "S": "2024-10-23T12:23:35.389Z"
  },
  "value": {
    "S": "paymentMethods": [
      {
        "name": "Cash",
        "paymentMethodBrand": "CASH",
        "isOnlinePayment": false
      },
      {
        "name": "Sodexo Voucher",
        "paymentMethodBrand": "SODEXO_VOUCHER",
        "isOnlinePayment": false
      }
    ]
  }
}
  • Payments Methods List:

    • name: a string used for easy identification of the payment method, and we can use this name to show on Sanity.

    • paymentMethodBrand: a string key that must match the one in WL_app. We will use this value to ensure consistent validation in the front-end.

    • isOnlinePayment: A boolean value to determine whether the payment method is online or offline. Initially, we will only use offline payment.

(plus) Pros:

  • Access restricted to the technical team;

  • With secrets, we can control payment methods by market and brand;

(minus) Cons:

  • When adding a new payment method in the WLapp, we also need to include it in the Secrets;

  • Need add the secrets for each stage (dev, stg, qa, prod);

  • Need to add this secrets in intl-packages/secrets

  • The Transactions team is currently working on an improvement to get the payment method for a service, so this secrets may be deprecated in the future.

PART II - Store Payment Methods with Their States in Sanity

In this section, we will explain how we will display this information in the DOP and how we will save the state of each payment method. All the solutions outlined above will use this approach to save the payment methods along with their states in Sanity.

This information will be stored in the Restaurant Document in Sanity, as each restaurant can have its own payment methods with their respective states. Therefore, the best location to save this information is within this Sanity Document.

How will we display the payment methods along with their states?
When we access the DOP on the Payment Methods screen, two queries will be executed:

  1. Retrieve the payment methods from Sanity in Payment Method;

  2. Retrieve the payment methods and their states from Sanity in the Restaurant Document.

If the restaurant has not yet configured the payment methods, we will display the screen as follows:

image-20241010-181837.png

Since the values have not been configured yet, they do not exist in Sanity on Restaurant Document. Therefore, only the values from the Payment Method of Sanity will be displayed, with the states set to undefined. image-20241010-181958.png

When the user makes any changes and selects the active and inactive payment methods, the system will save this information in Sanity, into the Restaurant Document similar to the Cash Limitation feature.

DOP

SANITY

image-20241010-182141.png

image-20241010-182603.png

The data we will save in Sanity in the Restaurant Document will have this format:

{
  "paymentMethods": [
    {
      "name": "Cash",
      "state": true,
      "paymentMethodBrand": "CASH",
      "isOnlinePayment": false
    },
    {
      "name": "Sodexo Voucher",
      "state": true,
      "paymentMethodBrand": "SODEXO_VOUCHER",
      "isOnlinePayment": false
    }
  ]
}

Once the configuration is set for the restaurant, every time the DOP opens the payment methods screen, it will perform the two queries again:

  1. Retrieve the payment methods from Sanity in Payment Method;

  2. Retrieve the payment methods and their states from Sanity in the Restaurant Document.

Now, the Sanity query will provide the status of each payment method, allowing the user to know which are active or inactive and make new modifications.

The Sanity Restaurant Document will only display this information for viewing purposes, it will not be possible to change these values or statuses through Sanity, only via the DOP.

Create the fields in Sanity alongside Cash Limitation and present the payment methods and their respective statuses. The file is schemas/menu/documents/restaurant.tsx.

PART III - How will the Whitelabel-app get this Information

intl-packages

We will create a new attribute in IBaseRestaurant in the file packages/sanity/src/restaurant/restaurant.ts.

The name of this attribute can be paymentMethod and it is an object:

export interface IPaymentMethod {
  name?: string
  state?: boolean
  paymentMethodBrand?: string
  isOnlinePayment: boolean
}

export interface IBaseRestaurant {
  ...
  paymentMethod?: IPaymentMethod[];
  ...
}

After this, we need to run the Sanity generate into the Sanity package.

And now the function listBySearchParams get this information on Sanity.

Create the paymentMethod field on GraphQL Flow

intl-whitelabel-graphql

Create a new attribute in RestaurantNode in the file src/functions/graphql/schemas/restaurant.gql

type PaymentMethod {
  name: string
  state: boolean
  paymentMethodBrand: string
  isOnlinePayment: boolean
}

type RestaurantNode implements Node {
...
  paymentMethod: [PaymentMethod]
...
}

Run graphql:types to create the file “generated”.

Create the paymentMethod on Gateway Flow

We need to insert the new atribute paymentMethod in RestaurantNode type on GraphQL.

type PaymentMethod {
  name: string
  state: boolean
  paymentMethodBrand: string
  isOnlinePayment: boolean
}

type RestaurantNode implements Node {
...
  paymentMethod: [PaymentMethod]
...
}
  1. Create this new field on Types in intl-fulfillment-servive, intl-delivery-service, intl-store-service

  2. We need to insert this field with @inaccessible directive documentation

  3. Only after this new field with @inaccessible be deployed in PROD we can start the integration between GraphQL (gateway) and WL-app (Front)

  4. remove @innaccessible directive and to make the integration of GraphQL

Note:
If we don’t insert the @inaccessible directive in PROD we can’t make the integration with front, and if we don’t use the @inaccessible, this will cause breaking changes on GraphQL and will block the pipelines.

intl-whitelabel-app

We can get this information on DeliveryRestaurant Query.

This query provides the information for the selected restaurant. Therefore, at the time of the order, we can access this information and validate the offline payments that are disabled for the restaurant.

Create a new hook to payments methods and call this hook on workspaces/frontend/src/pages/cart/payment/order-payment/paycomet-hosted-page-payment/paycomet-hosted-page-payment.tsx.

This file contains the list of payment methods, and we can use this list to compare it with the new payment list of restaurants.

Sanity and DOP Payments

Whitelabel Payments

Payments avaliable to user on payment screen

cash: true

Sodexo Voucher: false

Ticket Restaurant: false

Payment delivery card: true

Credit Card

Paypal

cash

Sodexo Voucher

Ticket Restaurant

Payment delivery card

Credit Card

Paypal

cash

Payment delivery card

To compare these payment methods, we will use the field paymentMethodBrand and onlinePayment in the first moment we’ll use only onlinePayment: false therefore only to offline payment.

The source of truth will always be the Whitelabel. If a payment method exists only in Sanity, the Whitelabel will not display it, as the payment method must be registered in the Whitelabel.

PART IV - Change Checkbox Components

Before:

image-20241008-170402.png

After:

image-20241008-170330.png

We can use the EditorAvailability component
workspaces/frontend/src/pages/editor/editor-grid/EditorAvailability.tsx

Example:

image-20241008-114709.png

And the setState we need to change as well, like this:

image-20241011-175404.png

This way we can change to 3 statuses, true, false and neutral:

False

True

Neutral

Remove the value or change to 0 the value of cash limitation

Allow we can put a value for cash limitation

Ignore the field, nothing will be changed, this behavior only happens when we choose more than one restaurant

image-20241008-114922.pngimage-20241008-114940.pngimage-20241008-114958.png


PART V - Payment Methods Schedule

In DOP, a possible solution would be to program how long the payment can be disabled.

image-20241011-185550.png

This Date component already exist on DOP.

Component:

<DateFilter/>

workspaces/frontend/src/pages/delivery/history/filters/OrderHistoryFilters.styled.ts

Sugestion:

Change the location of this component to a more generic location.

Figma file

https://www.figma.com/design/CeYjZSYqevJwE9Lp2emj5P/branch/axJnmgvzdxnAM5TpeI4czb/Digital-Ops-Portal?m=auto&node-id=7444-9557&t=R3Lky8nlZK6ubqSn-1




(warning) Potential Challenges

List here potential challenges that have come across the opportunity definition or from the potential solutions so far.

💰 Cost

Describe any additional cost this solution may imply.

🎛️ Configuration

Include here any configuration required (Sanity, LaunchDarkly flags, etc.) required to enable the solution.

  • A new feature flag enable-payment-method in Whitelabel-app and DOP

📈 Metrics

Describe the metrics that will be used to measure the solution’s success, as well as how to measure those KPIs.

🗓️ Delivery Plan

Link to the task or list of all the tasks required to deliver the solution, along with its progress.

🧑‍🚒 QA Plan

Testing scenarios. See example /wiki/spaces/EGMT/pages/4080861189.

⚠️ Call-outs

Tip: Document here any improvement or discussion regarding the feature

Which screen will the user be able to make these changes?

Users can make changes on the "Edit Payment Methods" screen located in the Restaurants tab. This screen is the same one used for Cash Limitation, so users with access to Cash Limitation will also be able to access the offline payment methods list.

If we add a new payment method only in the DOP, will it appear in the WL-app?

No, the new payment method will not appear. This request is solely for controlling the display of already existing offline payment methods.

If we configure the DOP to allow the SODEXO payment method, but we disable the flag for that payment in the WL-app, will it be displayed?

No, it will not be displayed, as the Whitelabel has greater control in this case.

Can I make changes directly in Sanity for the saved payment methods in the Restaurant Document?

No, editing must be done exclusively through the DOP.

Why will we save the payment status in Sanity?

Because Sanity is the true source of restaurant information. All details about the restaurant are stored in this document, so we will maintain this standard.

  • No labels